ASP.Net MVC - How to display string from view model inside html tag?

Question

<span class="text-danger">
@{
    if (Model.uploadErrorMessage != null)
    {
        if (!string.IsNullOrEmpty(Model.uploadErrorMessage))
        {
            Model.uploadErrorMessage;
        }
    }
}
</span>

Given code above, how do I display Model.uploadErrorMessage inside <span> tag?

Currently it give me this error on Model.uploadErrorMessage:

Only assignment, call, increment, decrement, and new object expressions can be used as a statement

Use `Html.Raw(Model.uploadErrorMessage)` or just `@Model.uploadErrorMessage`. — Tetsuya Yamamoto, Apr 27 '18 at 09:40
The outer `if` statement is made redundant by the inner one, and you can remove them both anyway - see my answer. — DavidG, Apr 27 '18 at 09:45

score 5 · Accepted Answer · answered Apr 27 '18 at 15:26

5

Put your span tag inside if statement

@{
    if (Model.uploadErrorMessage != null)
    {
        if (!string.IsNullOrEmpty(Model.uploadErrorMessage))
        {
            <span class="text-danger">@Model.uploadErrorMessage</span>
        }
    }
}

answered Apr 27 '18 at 15:26

Van VO

637
3
10

score 4 · Answer 2 · answered Apr 27 '18 at 09:44

4

All of those if statements are completely unnecessary anyway, you can simplify the entire thing to this:

<span class="text-danger">@Model.uploadErrorMessage</span>

answered Apr 27 '18 at 09:44

DavidG

113,891
12
217
223

I may put at least one `if` that embrace the span and not adding an empty DOM to the page when the message is null or empty:-) – CodeNotFound Apr 27 '18 at 10:04
@CodeNotFound Well yes, around the `span` would be different, but it's possible the empty span is required due to some Javascript thing perhaps. – DavidG Apr 27 '18 at 10:05

score 0 · Answer 3 · answered Apr 27 '18 at 09:42

0

use the "@"-symbol to write your variable value to the view:

for example:

<span>This is the error: @(Model.uploadErrorMessage)</span>

answered Apr 27 '18 at 09:42

G43beli

3,835
4
21
28

manish · Answer 4 · 2018-04-27T10:09:14.287

-1

~~@Html.Raw(Model.uploadErrorMessage)~~

you can simply put @Model.uploadErrorMessage

Edit: XSS vulnerability fix, based on @DavidG's comment.

edited Apr 27 '18 at 10:09

answered Apr 27 '18 at 09:41

manish

1,450
8
13

That's a bit dangerous though, would absolutely not recommend doing it that way. See here: https://stackoverflow.com/questions/11144943/is-there-a-risk-in-using-html-raw – DavidG Apr 27 '18 at 09:41
thanks @DavidG, would you mind elaborating a bit on `That's a bit dangerous` – manish Apr 27 '18 at 09:49
Yes, see the link I gave, and here http://kevinchalet.com/2018/01/09/why-you-should-never-use-html-raw-in-your-razor-views/ – DavidG Apr 27 '18 at 09:50
Well now your answer is the same as the existing one, and the big "edit" banner is not needed. – DavidG Apr 27 '18 at 10:03
yeah, that'll help others – manish Apr 27 '18 at 10:05
How will it help beyond the other answers though? It's just duplicate content. – DavidG Apr 27 '18 at 10:05
I meant the "edit" banner, but I got the context, many thanks once again – manish Apr 27 '18 at 10:10

ASP.Net MVC - How to display string from view model inside html tag?

4 Answers4