Angular4 ng-content gets built when ngIf is false

Question

I have a problem with the new ng-content transclusion.

Let's say I have a component my-component that, in its ngOnInit() function does some heavy operation on load (for now, just a console.log()).

I have a wrapper, that displays the content via transclusion (my-wrapper.component.html).

<ng-content></ng-content>

If I set the surroundings up like this, the log statement doesn't show:

<my-wrapper *ngIf="false">
    <my-component></my-component>
</my-wrapper>

I assume, the my-wrapper component does not get built, so the content is ignored.

But if I try to move the logic into the my-wrapper component like this (my-wrapper.component.html):

<ng-container *ngIf="false">
    <ng-content></ng-content>
</ng-container>

I always see the console.log() output. I guess, the my-component gets built and then stored away until the *ngIf becomes true inside my-wrapper.

The intention was to build a generic "list-item + detail" component. Say I have a list of N overview-elements (my-wrapper), that get rendered in a *ngFor loop. Every of those elements has its own detail component (my-component) that is supposed to load its own data, once I decide to show more infos to a specific item.

overview.html:

<ng-container *ngFor="let item of items">
    <my-wrapper>
        <my-component id="item.id"></my-component>
    </my-wrapper>
</ng-container>

my-wrapper.component.html:

<div (click)="toggleDetail()">Click for more</div>
<div *ngIf="showDetail">
    <ng-content></ng-content>
</div>

Is there a way to tell Angular, to ignore the transcluded content until it is necessary to be added to the page? Analogously to how it was in AngularJS.

I would suggest instead of adding condition on wrapper add the condition to child component to stop the execution — Jameel Moideen, Jul 05 '17 at 15:02
https://stackoverflow.com/questions/41652919/instantiate-transcluded-components-depending-on-their-dom-state-in-angular-2 — Viktor Lova, Jul 05 '17 at 15:04

score 19 · Accepted Answer · answered Jul 06 '17 at 06:19

Based on the comment of @nsinreal I found an answer. I find it to be a bit abstruse, so I'm trying to post it here:

The answer is to work with ng-template and *ngTemplateOutlet.

In the my-wrapper component, set up the template like this (my-wrapper.component.html):

<div (click)="toggleDetail()">Click for more</div>
<div *ngIf="showDetail" [hidden]="!isInitialized">
    <ng-container *ngTemplateOutlet="detailRef"></ng-container>
</div>

Note, that the [hidden] there is not really necessary, it hides the "raw" template of the child until it decides it is done loading. Just make sure, not to put it in a *ngIf, otherwise the *ngTemplateOutlet will never get triggered, leading to nothing happening at all.

To set the detailRef, put this in the component code (my-wrapper.component.ts):

import { ContentChild, TemplateRef } from '@angular/core';

@Component({ ... })
export class MyWrapperComponent {
    @ContentChild(TemplateRef) detailRef;

    ...
}

Now, you can use the wrapper like this:

<my-wrapper>
    <ng-template>
        <my-component></my-component>
    </ng-template>
</my-wrapper>

I am not sure, why it needs such complicated "workarounds", when it used to be so easy to do this in AngularJS.

score 2 · Answer 2 · answered Jul 05 '17 at 15:08

By doing this:

<my-wrapper *ngIf="false">
    <my-component></my-component>
</my-wrapper>

You are not calling MyComponent component, because the *ngIf is false. that means, that not calling it you are not instancing it and, therefore, not passing through its ngOnInit. And that's why you are not getting the console log.

By doing this:

<ng-container *ngIf="false">
    <ng-content></ng-content>
</ng-container>

You are inside the component, you are just limiting what to render in your template, but you already instanced your component and, therefore, you passed through your ngOnInit and you get your console log done.

If, you want to limit something (component call with selector or a ng-content or even a div) until you have some data available, you can do the following:

datasLoaded: Promise<boolean>;

this.getData().subscribe(
       (data) => {
            this.datasLoaded = Promise.resolve(true); // Setting the Promise as resolved after I have the needed data
       }
);

And in your template:

<ng-container *ngIf="datasLoaded | async">
   // stuff here
</ng-container>

Or:

<my-component *ngIf="datasLoaded | async">
   // Didn't test this one, but should follow the same logic. If it doesn't, wrap it and add the ngIf to the wrapper
</my-component>

I don't think this works in my case. The intention was this: I have a list of overview-data, that get rendered in a `*ngFor`-loop (`my-wrapper`). For every overview-item I have a second "detail" component (`my-component`), that is supposed to load its own data (by ID of the overview-item), once I toggle the parent (the `*ngIf`). If I try your approach, all the details will fire immediately, causing hundreds of expensive API calls. I guess I could integrate the `my-component` more into `my-wrapper`, but this makes it less generic, which is disappointing. — Cabadath, Jul 06 '17 at 05:30

score 2 · Answer 3 · answered Sep 24 '20 at 01:14

2

It’s because Ng content happens at the build time and when you pass the content it is actually not removed or recreated with the ngIf directive. It is only moved and the component is instantiated .

answered Sep 24 '20 at 01:14

anonymous

1,499
2
18
39

score 0 · Answer 4 · answered May 11 '21 at 22:19

I encountered this problem recently as well but settled on a different solution than the currently accepted one.

Solution (TL;DR)

(Solution is for AngularDart; I figure it's similar in Angular though)

Use a structural directive; tutorials linked below.

Instead of:

<my-wrapper>
  <my-contents></my-contents>
</my-wrapper>

your usage becomes:

<div *myWrapper>
  <my-contents></my-contents>
</div>

which is shorthand for the following (in AngularDart; I think Angular uses <ng-template>)

<template myWrapper>
  <div>
    <my-contents></my-contents>
  </div>
</template>

The MyWrapper directive logic is similar to NgIf except it has its own logic to compute the condition. Both of the following tutorials explain how to create an NgIf-like directive and how to pass it your own inputs using the special microsyntax (e.g. *myWrapper="myInput: expression"). Note that the microsyntax doesn't support outputs (@Output), but you can mimic an output by using an input that is a function.

Tutorial for Angular

Tutorial for AngularDart

Caveat: Since this is just a directive, it shouldn't do anything more complicated than instantiating a template ref at the appropriate time and maybe specifying some DI providers. For example, I would avoid trying to apply styles or instantiating a complex tree of components in the directive. If I wanted to create a list component, I would probably take the @ContentChild(TemplateRef) approach described in another answer; you would lose the asterisk shorthand for creating <template> but you would gain the full power of components.

My problem

My team owns an app that's part of a larger web application with other apps owned by other teams. Our components assume they can inject a MyAppConfiguration object, but this object can only be injected after it is loaded with an asynchronous request. In our app this is not a problem: we have a "shell" component that hides everything behind an ngIf until the configuration is loaded.

The problem is when other teams want to reference our components. We don't want them to duplicate the "wait until configuration is loaded" logic every time, so I tried creating a wrapper component that can be used like so:

<my-app-wrapper>
  <my-app-component></my-app-component>
</my-app-wrapper>

The wrapper injects a service object and hides its contents behind an ngIf until the service says that the configuration is loaded.

Like the question poster, I discovered that the ng-content approach doesn't work as intended: while the contents are correctly hidden from the DOM, Angular still instantiates the components causing dependency injection to fail.

The solution that I settled on was to rewrite the wrapper component as a structural directive.

Angular4 ng-content gets built when ngIf is false

4 Answers4

Solution (TL;DR)

My problem

Linked