Getting Infinite Loop when starting intent inside onCreate()

Question

I am new to Android and have come across a problem while implementing it. I'm trying to navigate the user to the MainActivity.java activity if the user has already logged in and if the user hasn't logged in then it will have navigate to the LoginActivity.java.

This is the code inside onCreate() method of my MainActivity.java.

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    name = (TextView) findViewById(R.id.tvName);
    prefs = PreferenceManager.getDefaultSharedPreferences(this);

    Gson gson = new GsonBuilder().create();
    Retrofit retrofit = new Retrofit.Builder()
            .baseUrl(BASE_URL)
            .addConverterFactory(GsonConverterFactory.create(gson))
            .build();

    sponsorApi = retrofit.create(SponsorInterface.class);

    if (prefs.getBoolean(Constants.IS_LOGGED_IN, false)){
        Intent intent = new Intent(MainActivity.this, MainActivity.class);
        startActivity(intent);
        user = prefs.getString(Constants.USER, "Username");
        Call<Sponsor> sponsorRequest = sponsorApi.getSponsor(user);
        sponsorRequest.enqueue(new Callback<Sponsor>() {
            @Override
            public void onResponse(Call<Sponsor> call, Response<Sponsor> response) {
                int statusCode = response.code();
                final Sponsor sponsor = response.body();
                name.setText(sponsor.getName());
                Log.d("SponsorDetails Activity", "onResponse: " + statusCode);
            }

            @Override
            public void onFailure(Call<Sponsor> call, Throwable t) {
                Log.d("LoginActivity", "onFailure: " + t.getLocalizedMessage());
            }
        });

    }else {
        Intent intent = new Intent(MainActivity.this, LoginActivity.class);
        Toast.makeText(getBaseContext(), "Please login to proceed", Toast.LENGTH_SHORT).show();
        startActivity(intent);
    }
}

When I run the app, it works but the Activity runs into infinite loop and I don't know what is causing the loop.

Update1: Debugger PS: SponsorDetails.java in image is MainActivity.java of the question.

Update2: Removing Intent of MainActivity As suggested in the comments I removed

Intent intent = new Intent(MainActivity.this, MainActivity.class);
startActivity(intent);

But still I am getting the infinite loop in onResponse() method. Yes, after removing the code, I uninstalled the app from emulator and re-ran the app from IDE.

Update 3: onStart() method

@Override
protected void onStart() {
    super.onStart();

    if (prefs.getBoolean(Constants.IS_LOGGED_IN, false)){
        Intent intent = new Intent(MainActivity.this, MainActivity.class);
        startActivity(intent);
    }else{
        Intent intent = new Intent(MainActivity.this, LoginActivity.class);
        Toast.makeText(getBaseContext(), "Please login to proceed", Toast.LENGTH_SHORT).show();
        startActivity(intent); 
    }
}

`Intent intent = new Intent(MainActivity.this, MainActivity.class)` - Why would you want to start the `Activity` you're already in again? — Mike M., Apr 18 '17 at 08:46
Why : `Intent intent = new Intent(MainActivity.this, MainActivity.class);` — Satan Pandeya, Apr 18 '17 at 08:46
@AnjanaSharma Inside `onCreate` method, check the login `token`. If `token` is available, then navigate, go to `YourActivity`, otherwise make a login api call or goto login. — Satan Pandeya, Apr 18 '17 at 09:11
Do you have any other functions in your `MainActivity` like `onStart()` — Luzan Baral, Apr 18 '17 at 10:04

score 1 · Answer 1 · answered Apr 18 '17 at 08:54

1

You are calling the MainActivity recursively in if condition,
So when the condition is true MainActivity gets called again and again.

remove two lines

Intent intent = new Intent(MainActivity.this, MainActivity.class);
startActivity(intent);

or change the activity name you want to go to in if condition.

answered Apr 18 '17 at 08:54

Nirav Madariya

1,470
2
24
37

I removed the lines but I'm still getting the infinite loop. Thank you for your reply. And now Emulator is also not responding. – Anjana Sharma Apr 18 '17 at 08:56
First Restart Emulator, and then try to Re-Run your app from your IDE. – Nirav Madariya Apr 18 '17 at 08:58
Yes, I restarted emulator, uninstalled the app and then re-ran the app again from IDE, but the problem still exists. – Anjana Sharma Apr 18 '17 at 09:04
can you update the error log (Debugger) and the onCreate()?, It will help to identify error. – Nirav Madariya Apr 18 '17 at 09:11

score 0 · Answer 2 · answered Apr 18 '17 at 08:51

0

Basically, your main activity keeps starting itself, and these are the two lines of code causing it. Just remove them.

    Intent intent = new Intent(MainActivity.this, MainActivity.class);
    startActivity(intent);

answered Apr 18 '17 at 08:51

Mohammed Bakr Sikal

357
2
7

Luzan Baral · Accepted Answer · 2017-04-18T10:07:57.363

0

Replace your onStart() with this

@Override
protected void onStart() {
    super.onStart();
    if (!prefs.getBoolean(Constants.IS_LOGGED_IN, false)){
        Intent intent = new Intent(MainActivity.this, LoginActivity.class);
        Toast.makeText(getBaseContext(), "Please login to proceed", Toast.LENGTH_SHORT).show();
        startActivity(intent); 
    }
}

Let me know if this helps?

edited Apr 18 '17 at 10:07

answered Apr 18 '17 at 09:29

Luzan Baral

3,678
5
37
68

score -1 · Answer 4 · answered Apr 18 '17 at 08:52

I think you are not updating the logged in status in preferences

Update the status like below

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    name = (TextView) findViewById(R.id.tvName);
    prefs = PreferenceManager.getDefaultSharedPreferences(this);

    Gson gson = new GsonBuilder().create();
    Retrofit retrofit = new Retrofit.Builder()
            .baseUrl(BASE_URL)
            .addConverterFactory(GsonConverterFactory.create(gson))
            .build();

    sponsorApi = retrofit.create(SponsorInterface.class);

    if (prefs.getBoolean(Constants.IS_LOGGED_IN, false)){
        Intent intent = new Intent(MainActivity.this, MainActivity.class);
        startActivity(intent);
        user = prefs.getString(Constants.USER, "Username");
        Call<Sponsor> sponsorRequest = sponsorApi.getSponsor(user);
        sponsorRequest.enqueue(new Callback<Sponsor>() {
            @Override
            public void onResponse(Call<Sponsor> call, Response<Sponsor> response) {
                int statusCode = response.code();
                final Sponsor sponsor = response.body();
                name.setText(sponsor.getName());
                Log.d("SponsorDetails Activity", "onResponse: " + statusCode);

                // update the IS_LOGGED_IN status as true
                SharedPreferences.Editor editor = pref.edit();
                editor.putString(Constants.IS_LOGGED_IN ,true);
                editor.commit();

            }

            @Override
            public void onFailure(Call<Sponsor> call, Throwable t) {
                Log.d("LoginActivity", "onFailure: " + t.getLocalizedMessage());
            }
        });

    }else {
        Intent intent = new Intent(MainActivity.this, LoginActivity.class);
        Toast.makeText(getBaseContext(), "Please login to proceed", Toast.LENGTH_SHORT).show();
        startActivity(intent);
    }
}

Please have a try . This will solve your problem

Getting Infinite Loop when starting intent inside onCreate()

4 Answers4